-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Meshes: Kuma, App Mesh, Consul, Cilium #52
Conversation
Ready to try this out? |
@leecalcote Yes, I'm working on it. One question is that no every service mesh has its own demo apps, I found Kuma has one but app mesh, consul and cilium may not. Can we use Istio's bookinfo app as a alternative? |
Yep I tried this exercise for Cilium and Consul and both of them do not have a sample app, atleast nothing like bookinfo or emojivoto for istio and linkerd @leecalcote should we try creating some simple applications? |
Got this for consul :- https://github.com/hashicorp/learn-consul-k8s-hashicups/tree/main/hashicups I guess this might work. This is a pattern divided into 4 files. Apparently we might have to append these files into one and then apply the pattern. This came out in todays CI meeting. To be specific out of @Zanda256 and @Revolyssup 's conversation. All credits to them |
Another thought, is it worth making one common pattern, say bookinfo for all service mesh adapters. This gives us a common pattern to test for SMP.... if that's something we want |
This will be a lot of heavy lifting. Maybe for cilium, since it's a new project and the makers haven't released a sample app yet. |
@hershd23 Yes, I think we should. I will try |
Signed-off-by: Huang Xin <[email protected]>
Signed-off-by: Huang Xin <[email protected]>
Signed-off-by: Huang Xin <[email protected]>
Signed-off-by: Huang Xin <[email protected]>
Signed-off-by: Huang Xin <[email protected]>
Signed-off-by: Huang Xin <[email protected]>
Signed-off-by: Huang Xin <[email protected]>
Signed-off-by: Huang Xin <[email protected]>
Signed-off-by: Huang Xin <[email protected]>
I failed to deploy app-mesh and cilium adapters,
https://github.com/gyohuangxin/meshery-smp-action/runs/7183605286?check_suite_focus=true#step:4:88
@leecalcote Do you have any ideas, is my command wrong? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
Still in draft? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
Signed-off-by: Huang Xin [email protected]
Description
This PR fixes #51
Notes for Reviewers
Signed commits